fix: export elementUpdated
#185
Conversation
| @@ -1,5 +1,5 @@ | |||
| import './vdiff.js'; | |||
|
|
|||
| export { assert, aTimeout, defineCE, expect, html, nextFrame, oneDefaultPreventedEvent, oneEvent, waitUntil } from '@open-wc/testing'; | |||
| export { assert, aTimeout, defineCE, elementUpdated, expect, html, nextFrame, oneDefaultPreventedEvent, oneEvent, waitUntil } from '@open-wc/testing'; | |||
There was a problem hiding this comment.
I was mostly expecting folks to just use await elem.updateComplete in these cases... were you relying on the extra stuff they have in there? If we don't think it's needed, I can update the migration guide to just call this out.
There was a problem hiding this comment.
I can take a look at not using it and see if I have any troubles. I was just doing my best to not change the tests if I didn't have to.
There was a problem hiding this comment.
I'll take a look tomorrow
There was a problem hiding this comment.
Ok let me know. I'm OK with adding it, but yeah it always struck me as odd to abstract it away when elem.updateComplete was right there. And then having it fall back to await nextFrame if the thing isn't a Lit element was just extra magic.
|
Worked fine without it. Not worth adding in that case. |
Was looking at switching outcomes over to this new framework and noticed that
elementUpdatedisn't exported from the@open-wc/testingpackage. Adding it so it's available unless there's a reason it was left out.Source: https://github.com/open-wc/open-wc/blob/master/packages/testing-helpers/src/elementUpdated.js
Looks like it basically does what you describe here just covering more cases.